plucko / ribbit

hot breakfast with a pluck
4 stars 11 forks source link

Reconcile duplicate code between controllers.js and presenter-rtc.js / audience-rtc.js #54

Open rjatkinson2 opened 9 years ago

rjatkinson2 commented 9 years ago

Currently, the factories utilized to generate presenterRTC and audienceRTC instances of baseRTC are included in the controllers.js file. Ideally, these factories would be defined in separate presenter-rtc.js and audience-rtc.js files, which currently exist in the folder structure. The code was included in controllers.js in favor of the separate files because the latter would produce the following error: "provider not defined error for audienceRTC -> audienceRTCProvider"