search

plucko / ribbit

hot breakfast with a pluck
4 stars 11 forks source link

User object should be referenced utilizing 'Room' service rather than $rootScope. #55

Open rjatkinson2 opened 9 years ago

rjatkinson2 commented 9 years ago

$rootScope was shamefully utilized to hack roomname and presenter information between controllers. The 'Room' service was setup to handle this functionality, and should be utilized instead.

image

sungminchang commented 9 years ago

Yeah I guess we'll discuss how we might use the Room service. On Mar 23, 2015 7:57 AM, "Ryan Atkinson" notifications@github.com wrote:

$rootScope was shamefully utilized to hack roomname and presenter information between controllers. The 'Room' service was setup to handle this functionality, and should be utilized instead.

[image: image] https://cloud.githubusercontent.com/assets/3825178/6782569/2bbfb4b2-d132-11e4-8b8f-9fb4ece8bb20.png

— Reply to this email directly or view it on GitHub https://github.com/plucky-oatmeal/plucky-oatmeal/issues/55.

sungminchang commented 9 years ago

That's my bad since my code lacks comments.