search

pludoni / simple-captcha

Rails 3+4 support now! Simple Captcha is the simplest and a robust captcha plugin. Its implementation requires adding up a single line in views and in controllers/models.
MIT License
106 stars 73 forks source link

Fixes #29 #30

Closed rubyconvict closed 9 years ago

rubyconvict commented 10 years ago

Image is replaced but key is not because middleware has a hardcoded id in js: 'captcha_key', and hidden_field on specific model gives namespaced id by default.

Master branch is dirty now, and fails, because of this:

-        "#{ENV['RAILS_RELATIVE_URL_ROOT']}/simple_captcha?code=#{simple_captcha_key}&#{query}"
+        "#{request.protocol}#{request.host_with_port}#{ENV['RAILS_RELATIVE_URL_ROOT']}/simple_captcha?code

in the same file I applied my fix, so it's a different story... ok?

digaev commented 9 years ago

Why still not merged/fixed?

rubyconvict commented 9 years ago

Done in https://github.com/pludoni/simple-captcha/commit/f1efa05a6fb8a2f43278d2d51df8c9cd1cbf5d8c