search

pludoni / simple-captcha

Rails 3+4 support now! Simple Captcha is the simplest and a robust captcha plugin. Its implementation requires adding up a single line in views and in controllers/models.
MIT License
106 stars 73 forks source link

Rails 5 support #53

Closed deivid-rodriguez closed 7 years ago

deivid-rodriguez commented 7 years ago

The gem already works against Rails 5 but gives several warnings.

This PR fixes those warnings and upgrades the test matrix and makes it pass against more recent versions of dependencies.

zealot128 commented 7 years ago

Thanks for the work!

Could you please rebase+squash your changes a little to a handful of commits, to minimize the number of commits, like "Fix warning"?

https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request#squash-your-changes

deivid-rodriguez commented 7 years ago

I try to split commits into logical units, so I would consider fixing one warning different from fixing another one. Imagine someone reading these commits wants to fix those same warnings in another application. A single commit with all the fixes in it wouldn't help as much as having each warning isolated in a single commit.

If you still want me to squash commits, please let me know the groups of sha's that should be squashed together.

Thanks.

deivid-rodriguez commented 7 years ago

Thanks!