search

plugCubed / plugAPI

A generic API for creating plug.dj bots
MIT License
78 stars 45 forks source link

Request For Comments/Feedback : EventObjectTypes #48

Closed TATDK closed 9 years ago

TATDK commented 9 years ago

I have just committed a change for the event objects and I would like some feedback. Commit: 8b12f898bd2762b3a208b7af2385fb91f93c1ea4

The idea is simply to convert plug.dj socket objects to easier to read objects. So for example, the advance contains a d variable, which this system converts to djs. Thereby, the messagehandler doesn't need to contain code for this and simply break to the end (emitting the event) instead of emitting the created object inside the switch and returning.

thedark1337 commented 9 years ago

improving readability is always a good thing imo, i dont really see any disadvantage of rewriting like this , just a bit more work to redo the documentation and tell people to use the newer vars which isn't hard at all. We are doing an unofficial API so this makes the most sense too :P

avatarkava commented 9 years ago

Good idea, as it also insulates against further changes on plug's side (only plugAPI needs to be updated to handle the new variable names, not the code utilizing it as well).

ronaldb commented 9 years ago

You got my vote.

NiNewit commented 9 years ago

:+1: sounds good to me

TATDK commented 9 years ago

Thanks a lot for the comments :+1: