plugdata-team / plugdata

Pure Data as a plugin, with a new GUI
https://plugdata.org
GNU General Public License v3.0
1.48k stars 64 forks source link

Bug - dark theme: no contrast between slider labels and sliders in many tutorials #1171

Open PowerUser64 opened 1 year ago

PowerUser64 commented 1 year ago

When using dark theme, there is no contrast between the labels on many sliders and the sliders themselves in the tutorials. The reason for this is the sliders are still light theme. Compare these to screenshots. Notice how the labels for the controls on the bandpass~ are the same color as the slider in dark theme, making them impossible to read. The same is true for lables for the units on each axis on the graph. Additionally, notice how changing themes doesn't change the colors of the ui on the out~ object.

Note: it might help to compare these by opening each in its own browser tab and using ctrl+page up/page down to switch between them seamlessly.

image

image

timothyschoen commented 11 months ago

This is pretty hard to solve, comments don't have a settable colour property, so all we can do is colour them according to the current theme. When that is combined with components that do have customisable colour, this can become hard to read. The easiest cure is to use the light theme, I'm not sure if we can really solve this.

60-hz commented 11 months ago

Using comment RGB color value of (100, 100,100) for light theme and (140, 140,140) for dark theme, comment are bit dimmed in dark, which is the purpose of the theme, and give me an acceptable results on both cases. Tested on macbook in average ambient conditions... don't know if other screens could be readable...

Capture d’écran 2023-09-27 à 12 12 03 Capture d’écran 2023-09-27 à 12 10 24