search

plugdata-team / plugdata

Pure Data as a plugin, with a new GUI
https://plugdata.org
GNU General Public License v3.0
1.54k stars 66 forks source link

PluginProcessor.cpp: line 856, sends "position" info to wrong object #1490

Closed jocphx closed 6 months ago

jocphx commented 7 months ago

Hi, I noticed that the position param of playhead is not receiving any data from the DAW. I tested this in FL Studio and Ableton.

I gave a quick look at the code, and beside seeing a comment in playhead.md in regard to the position param not working, I saw that in PluginProcessor.cpp at line 856 of main, the position message is sent to a wrong object:

sendMessage("playhead", "position", atoms_playhead);

Shouldn't that be sendMessage("_playhead", "position", atoms_playhead); ? (that is underscore prepended to playhead)

It looks like the playhead object in 8.0.2 was changed to _playhead in 8.0.3 but that last message fell through the cracks.

dromer commented 7 months ago

Indeed, this last one hasn't been changed yet: https://github.com/plugdata-team/plugdata/blob/develop/Source/PluginProcessor.cpp#L901

(the receiver was renamed in order to have lower chance of clashing with user patches)

jocphx commented 7 months ago

Any idea when you'll be able to address that?

I have a few generative sequencers that I wrote using Camomile, (which rely on position) and I was hoping to port them to your environment.

jocphx commented 7 months ago

... and you can probably also close https://github.com/plugdata-team/plugdata/issues/1480 (that's mine too) as known bug

dromer commented 7 months ago

Any idea when

Create a pull request, get it merged.

jocphx commented 7 months ago

when I clone the project locally, do I make my feature branch from develop , nvg_test, main? I gave a quick look to the other pull requests and they all seem to be merged with nvg_test, but it doesn't hurt asking.

timothyschoen commented 6 months ago

I applied your fix in 07ecf990e, thanks for letting me know about this!

The nvg_test branch is a temporary feature branch that will soon be merged into develop, so for future reference, develop is the best place to send your PRs to.