plugdata-team / plugdata

Pure Data as a plugin, with a new GUI
https://plugdata.org
GNU General Public License v3.0
1.57k stars 66 forks source link

Implement patch thumbnails for welcome panel. #1844

Closed alcomposer closed 2 months ago

alcomposer commented 2 months ago

image

timothyschoen commented 2 months ago

Nice! I wonder if we should use SVG instead? That way we can ensure it looks good on retina.

alcomposer commented 2 months ago

The images are auto scaled. So you can make the image retina size, (realistically they are still drawing very small, so 1024x1024 would be more than enough).

Edit: I believe kontakt suggests very small thumbnails (120x60px). I suppose the idea is a thumbnail is intended to provide graphic context, not text. And at the size they are displayed they work best this way.

The current scaling works both ways however, so a small image will be scaled up, large scaled down. We can have 'suggested settings' in the manual for these thumbnails (same as kontakt does) for best size / safe area.

The images are still rendered in plugdata's graphics context as snapshotImage = NVGImage(nvg, bounds.getWidth() * 2, (bounds.getHeight() - 32) * 2,

So whatever the user / plugin maker provides will work.

Here is an example of a 10x10 png. Maybe some peeps are into pixel art? :-D image

dromer commented 2 months ago

maybe use _thumb.png instead? shorter and more direct ;)

alcomposer commented 2 months ago

Nice! I wonder if we should use SVG instead? That way we can ensure it looks good on retina.

We could do both? As vector graphics would be smaller also (depending on the data)

alcomposer commented 2 months ago

maybe use _thumb.png instead? shorter and more direct ;)

I'm not sure about using a shorter name. It's quite trivial to change, but _thumbnail is clearer? Thoughts? Currently I changed it to use _thumb

I don't have any strong feelings either way.

dromer commented 2 months ago

I think _thumbnail is too much typing and rather verbose (especially if the patch name is short) and _thumb is already clear enough to the majority of users. Maybe could do both? (first one found is used)

Either way there should be clear instructions somewhere that explain this feature, of course.

alcomposer commented 2 months ago

Good points. And yes we need the manual for more than just this also!

We need a whole section on how plugin mode works anyway, and how to use it. Including the plugin mode theme, latency compensation, this, and others.