search

plugdata-team / plugdata

Pure Data as a plugin, with a new GUI
https://plugdata.org
GNU General Public License v3.0
1.58k stars 67 forks source link

Bug: new patch keeps asking for save location #1952

Closed dromer closed 5 days ago

dromer commented 1 week ago

When opening a new patch we automatically get a file dialog asking for a save location. This by itself is already quite annoying, but even when we close it and then adding any new object to the patch it re-opens the file dialog again.

Imo plugdata should not force the user to save a patch. Pd-vanilla doesn't do this either and it's quite annoying when sometimes you just want to do a quick sketch without saving anything.

dromer commented 1 week ago

Hmm it seems even more buggy than this. Even after saving the patch it keeps popping up the file dialog whenever I make a change.

tmhglnd commented 5 days ago

We are encountering this issue as well with the Nightly built 09dae8b. And when you try to save plugdata crashes. Below the crash report. This was on MacOS Sonoma 14.6.1.

pdcrash.txt

https://github.com/user-attachments/assets/b404a9f1-95a7-4823-9501-8cbd7f296f7e

timothyschoen commented 5 days ago

We are encountering this issue as well with the Nightly built 09dae8b. And when you try to save plugdata crashes. Below the crash report. This was on MacOS Sonoma 14.6.1.

pdcrash.txt pdcrash.mov

The crash was just fixed with 09dae8b5c307a2435b45f5d7820fbf8e61b3859b, sorry for that!

There are still some issues with MIDI on nightly, working on that now

dromer commented 5 days ago

And it seems that we no longer get the insistent patch saving file dialog!

timothyschoen commented 5 days ago

And it seems that we no longer get the insistent patch saving file dialog!

oh, now I'm thinking about it, that makes sense!

Should be fixed then

dromer commented 5 days ago

:crossed_fingers:

tmhglnd commented 4 days ago

For me this is not fixed in the nightly that I just downloaded (09dae8b) (but maybe the fix comes up later online?), and it still crashes PlugData when I try to save.

Also I lost all my settings, there was some error that popped up when I opened this install. Not a big deal, was mainly custom shortkeys.

dromer commented 4 days ago

Crashing was not part of this bug report. I think that must have a different reason.

For the corrupt settings there is already a report here: https://github.com/plugdata-team/plugdata/issues/1941

timothyschoen commented 4 days ago

Crashing was not part of this bug report. I think that must have a different reason.

That was a part of the same bug. Just that memory errors sometimes cause crashes and sometimes don't. It can depend on the compiler, OS or CPU architecture.

I'll also look at the corrupted settings issue. The problem is that it checks if the settings file is not corrupted, but that check is very strict. I think it can be a bit less strict.

@tmhglnd The nightly builds didn't complete successfully the first time, that's fixed now. Be careful though, I'm working on a few things, you could run into some bugs.