search

plugdata-team / plugdata

Pure Data as a plugin, with a new GUI
https://plugdata.org
GNU General Public License v3.0
1.54k stars 66 forks source link

credits #3

Closed porres closed 2 years ago

porres commented 2 years ago

hi, nice work, is this based on https://github.com/porres/Camomile-ELSE? If so, can you give me and @emviveros credits as well? cheers

timothyschoen commented 2 years ago

Whoops I forgot, you're in there now!

porres commented 2 years ago

Hi, please note credits for ELSE is mine, but @emviveros takes care of on the 'Camomile-ELSE' branch, which I think you are using as the basis of this project, right? We need to clear this out in the credits and info. https://github.com/porres/Camomile-ELSE

timothyschoen commented 2 years ago

Ah yeah I was a bit unsure who to credit. I used the externals included in Camomile-ELSE because they were organised in a way that was easier for me to include for this project... But I assumed they're mostly the same as the ones in the regular ELSE library. I didn't use any other code specific to Camomile-ELSE so if you agree I could just credit you for the ELSE library? (Or I could change the name/link to go to Camomile-ELSE, whichever you prefer)

porres commented 2 years ago

I'm not sure, you decide :)

porres commented 2 years ago

what version of ELSE are you using? I just tried loading the plugin in Live and Live crashed :/

timothyschoen commented 2 years ago

That's unfortunate, what OS/format did you use? I'll check it out soon, I actually haven't tested it in Live yet. I don't think ELSE is to blame for the crash though.

I'm using the latest version of the master branch of Camomile-ELSE, but with fixes for the bugs I reported to you a few weeks ago. It might be a good idea to start using your main ELSE repository for the latest fixes.

porres commented 2 years ago

which issues? which fixes? Why don't you send me PRs so I accept them? I'm on Mojave

timothyschoen commented 2 years ago

https://github.com/porres/pd-else/issues/1128 https://github.com/porres/pd-else/issues/1127

You've already fixed these for ELSE, but they're probably still in Camomile-ELSE. Should be quick fixes.

timothyschoen commented 2 years ago

Btw, did you clone a recent version or use the released version?

porres commented 2 years ago

I used the release version

porres commented 2 years ago

it's also crashing in audacity :/ have you had a successful test in macOS? which version and which software?

timothyschoen commented 2 years ago

I think I've put the release up a bit too soon, I've found quite a few new bugs since then. I also realised I forgot to codesign my macOS release, that doesn't help. I'll put a new release up very soon, when I'm a bit more certain that it's going to work.

The last commit should probably work if you build it yourself. I've tested recent versions on Monterey, in Logic, Reaper and Bitwig.

timothyschoen commented 2 years ago

The release version does work for me in Ableton 10 (both VST3 and AU), which is strange. I did upload a small hot fix two days ago, perhaps you downloaded it before that? If that's the case then it's hopefully already fixed

porres commented 2 years ago

no, i downloaded yesterday

timothyschoen commented 2 years ago

I've uploaded a new release which for minimum macOS version 10.11, that should fix it