plugdj / Issues-and-Reports

8 stars 1 forks source link

Mention in "emote"-type messages don't get highlights. #19

Open Burkes opened 6 years ago

Burkes commented 6 years ago

PLATFORM Issue

Web App Issue

plug.dj version

1.5.6.11119

OS/Browser Name and Version

Windows 10 Home Version 1709 Build 16299.125 Google Chrome 64.0.3282.39 (Official Build) beta (64-bit)

I have tried

Description, Images, Logs

The message type is very strict and only accepts 1 value, meaning that if a message is an emote and contains mentions, the function in charge of adding the visual aspects of a mention ignores it for not having type === "mention". This could be worked around if messages could have "more types" (i.e. "message emote mention" at the same time.

Steps to reproduce:
  1. Have two accounts in a room.
  2. Mention one of the accounts with an emote message (/em @user)
  3. The sound of the mention will play for the other user, but it will not be highlighted in any way.

plug.dj username, profile link or user ID

@Burkes - 3703511