search

pluginkollektiv / antispam-bee

„... another popular solution to fight spam is Antispam Bee“ – Matt Mullenweg, Q&A WordCamp Europe 2014
https://wordpress.org/plugins/antispam-bee/
GNU General Public License v2.0
162 stars 26 forks source link

Replace/extend "delete after X days" option with "delete after X comments" #351

Open schlessera opened 4 years ago

schlessera commented 4 years ago

We currently have an option to delete stored spammed comments we use for improving the spam detection after a set amount of days.

However, the number of days is not a meaningful metric for deciding on this. We want to have the highest amount of spam for improving detection while not endangering the DB storage space.

On a very low traffic site, 30 days worth of spam comments might be a single comment, whereas a high traffic site might be completely filled up after 30 days.

It would make more sense to control the storage space by the number of stored spam comments instead. This optimizing for a large pool of stored spam comments to help improve detection while ensuring we have a hard limit on the maximum space requirement.

Zodiac1978 commented 4 years ago

This is a great idea!

How do we do the migration from the old day based setting?

Here is an idea for a migration path:

If the day setting is used, we could add the number setting as an additional setting and check both. If one of the conditions is triggered we delete the comment.

If the day setting is not used, we could hide it and just display the new setting.

After some time and with at least two upgrade notices (one for the introduction and one for the removing) we could remove the day based setting.

Feedback welcome!

krafit commented 3 years ago

Very much in favor of this idea and Torstens migration path!

krafit commented 3 years ago

Once we'll remove the day setting: should we just disable the new setting by default or set a sensible default value (maybe even based upon the previous setting). However: I'd love to see this in 2.10 🥳

pfefferle commented 3 years ago

What about a combination of both?

Delete after X days and/or X comments

stklcode commented 2 years ago

+1 for both

Storage limit is a valid point. But there is no real benefit in storing old spam on low-traffic sites, as patterns change. 100 comments should not yield any storage issues, but with <1 comment per week that’s already >2 years. Setting a limit of 5 however is not beneficial, if one day spammers start to target the site, s.t. we only capture the last 10 Minutes from that point on.

florianbrinkmann commented 2 years ago

I also think both options would be good