search

pluginkollektiv / antispam-bee

„... another popular solution to fight spam is Antispam Bee“ – Matt Mullenweg, Q&A WordCamp Europe 2014
https://wordpress.org/plugins/antispam-bee/
GNU General Public License v2.0
164 stars 27 forks source link

Add the missing type hint for `get_placeholder()` #629

Closed 2ndkauboy closed 1 month ago

2ndkauboy commented 1 month ago

Fixes #628

2ndkauboy commented 1 month ago

@stklcode should we also add type hints for the other methods in src/Admin/Fields/Field.php?

stklcode commented 1 month ago

It would not hurt, if possible. Wondering why I didn’t add these in #577 🤔

Guess the return type was not distinct across the missing functions and I didn’t want to change the actual logic, but probably just missed some.

I’m fine with this single change. If you want to add more you’re welcome and I can have a second look later.