pluginkollektiv / cachify

Smart but efficient cache solution for WordPress. Use DB, HDD, APC or Memcached for storing your blog pages. Make WordPress faster!
https://wordpress.org/plugins/cachify/
GNU General Public License v2.0
99 stars 31 forks source link

change composer action for deployment workflows #226

Closed stklcode closed 3 years ago

stklcode commented 3 years ago

The previous composer action adds some extra files to the project root. This PR resolves #218.

Those can be ignored, but the action used for testing is fast and allows to specify the exact PHP version whereas the composer action uses the latest stable (we stumbled upon this in other projects).

The shivammathur/setup-php@v2 version has proven to work since #217, so why not use the same workflow in all 3 recipes...

Zodiac1978 commented 3 years ago

Can anyone with composer knowledge/opinion help here? @pfefferle, @2ndkauboy , @florianbrinkmann or @patrickrobrecht ? If a second pair of eyes had a look I can merge this.

pfefferle commented 3 years ago

What about downloading the required composer as phar version?

pfefferle commented 3 years ago

And/or it seems possible to downgrade composer with for example composer self-update 1.4.1 to any version.

stklcode commented 3 years ago

The action in use is capable of doing that, if necessary (docs)

Just use tools: composer:v2, tools: composer:2.1.3 or similar instead of tools: composer.