pluginkollektiv / cachify

Smart but efficient cache solution for WordPress. Use DB, HDD, APC or Memcached for storing your blog pages. Make WordPress faster!
https://wordpress.org/plugins/cachify/
GNU General Public License v2.0
101 stars 32 forks source link

Raise required WordPress and PHP version #259

Closed pfefferle closed 2 years ago

pfefferle commented 2 years ago

WordPress needs at least PHP version 5.6.20+ (but recommends 7.4), so I would recommend to raise the required PHP version of cachify to 5.6 (and the required WordPress version accordingly).

-- https://wordpress.org/about/requirements/

stklcode commented 2 years ago

+1 for not sticking to legacy PHP.

Your suggestion for a reasonable minimum WP version? We currently support down to 4.4. REST API stuff (like #257) requires 4.7 anyway.

PHP 5.6 is required since WP 5.2. Older releases are backwards compatible to PHP 5.2 We can raise the requirements independently, personally I'd be fine with 5.6/4.7 (but don't have requirements for anything below WP 5.8)

florianbrinkmann commented 2 years ago

Oh, I thought the REST API was in core since 4.4 because register_rest_route was introduced there, but you are right, it was 4.7.

How would we raise the versions? Add a note to a release that we will raise it in the next release, so people with older versions are informed about it, or just raise it from one version to the other?

krafit commented 2 years ago

My 2 cents: I'd raise to 5.6/4.7 in 2.4.0. It's safe to assume, users with super old PHP / WP versions don't update their plugins regularly.

stklcode commented 2 years ago

I didn’t check the code, maybe our route is already working with 4.4. We only need a very small fraction of the API features. Officially it’s 4.7.

If you are running such version not just because yo don’t care about the site, there are usually reasons for that like major customizations that cannot be simply adjusted and designed to live until the core is EOL (3.7 received security updates, so it could still be used for site core). Plugin updates, if any, usually require manual inspection anyway in that case.

florianbrinkmann commented 2 years ago

@angelocali and I just tried #257 with 4.4 and it worked (except a missing dashicon)