search

pluginkollektiv / cachify

Smart but efficient cache solution for WordPress. Use DB, HDD, APC or Memcached for storing your blog pages. Make WordPress faster!
https://wordpress.org/plugins/cachify/
GNU General Public License v2.0
99 stars 30 forks source link

changed $should_cache default #267

Closed karlkowald closed 2 years ago

karlkowald commented 2 years ago

from default to statuscode matching 200

stklcode commented 2 years ago

Besides the minor PHP version issue, code looks good to me. Thanks very much for this fix @karlkowald.

In general excluding 500s (which was the original intent) should be valid in almost any scenario.

Excluding errors like 404 is also a good idea in many cases. Caching them allows users/bots to fill up the cache requesting arbitrary, non-existing URLs. In the very same scene this wastes some processing time to not cache them.

I'm totally fine with a 200-only default here.