pluginkollektiv / cachify

Smart but efficient cache solution for WordPress. Use DB, HDD, APC or Memcached for storing your blog pages. Make WordPress faster!
https://wordpress.org/plugins/cachify/
GNU General Public License v2.0
99 stars 31 forks source link

migrate dashboard icons to icon-font #277

Open stklcode opened 1 year ago

stklcode commented 1 year ago

Using a font instead of custom inline-svg all default dashboard styles are applied to the Cachify icons, too.

Convert the current icons into a font using IcoMoon app and adjust the output accordingly. Preserve original SVG files, but do not distribute.

Inline WOFF2 to prevent additional requests for most modern browsers.


This PR contradicts the changes introduces in #64 where we migrated from OpenType font to SVG.

It is true that SVG can be considered superior to icon fonts in various cases, but the native WP icons use the Dashicons icon font and styling from themes, plugins, etc. does not apply to our SVG, i.e. the Cachify icon always has the default grayish color. So for the sake of consistency I would prefer using the same technology here.


resolves #264 for various dark mode plugins

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud