pluginkollektiv / cachify

Smart but efficient cache solution for WordPress. Use DB, HDD, APC or Memcached for storing your blog pages. Make WordPress faster!
https://wordpress.org/plugins/cachify/
GNU General Public License v2.0
99 stars 30 forks source link

[I18n] Fix brand names and Caching method label #297

Closed pedro-mendonca closed 11 months ago

pedro-mendonca commented 1 year ago

Description of these fixes:

stklcode commented 11 months ago

Thanks for this PR!

I do agree with almost all changes.

For "memcached" vs. "Memcached" it seems the author's use it with mixed capitalization as well. Seems capitalized in headlines, but all lowercase in the text ... most of the time.

About Memcached memcached is a high-performance, distributed memory object caching system, generic in nature, but originally intended for use in speeding up dynamic web applications by alleviating database load. [...]

What it Does memcached allows you [...] [...] With memcached, you can see [...]

Origin Memcached was originally [...]

https://memcached.org/about

Any source for the "correct" spelling?

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

pedro-mendonca commented 11 months ago

Any source for the "correct" spelling?

@stklcode the source was this plugin code, as there is another string nginx Memcached setup, so I've included the uppercase change for consistency. Still, I've already reverted that and excluded Memcached from the changes.

lloc commented 11 months ago

The PR is fine for me.