pluginkollektiv / statify

Statify – statistics plugin for WordPress
https://wordpress.org/plugins/statify/
GNU General Public License v3.0
76 stars 22 forks source link

copy third-party libs instead of using Composer autoloader (#256) #260

Closed stklcode closed 11 months ago

stklcode commented 1 year ago

fixes #256

The autoloader mechanism is quite heavy for a single dependency and requires composer and vendor dir to be part of the final product.

We yet have generated/minified resources in our project, so this is the minimalistic approach to copy the CrawlerDetect lib, too and extend the custom autoloader mechanism.


This is not a pretty solution, but the project is not really Composer compatible. (no PSR-4 namespaces, requirement for minified files that are generated from dev-dependencies, etc.).

This way we ca postpone the decision to heavily rework the project structures while having a runnable artifact again.

florianbrinkmann commented 11 months ago

The only thing missing here would be to add the CrawlerDetect file(s) to the lib folder, right?

stklcode commented 11 months ago

You're right, seems the line got lost at some point. Re-added the missing directory to the copy-file list in composer.json, so it's populated after composer install

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication