pluginkollektiv / statify

Statify – statistics plugin for WordPress
https://wordpress.org/plugins/statify/
GNU General Public License v3.0
76 stars 22 forks source link

update WPCS to v3.0 with minor code style tweaks #276

Closed stklcode closed 5 months ago

stklcode commented 10 months ago
sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

stklcode commented 5 months ago

Apparently this was already done in b2abe7a800f3d64b10c17a88699b475325c9dd54 and the only remaining change is superseded by #286. Closing this PR.

lloc commented 5 months ago
  • use printf() instead of echo sprintf()

Is there an advantage to using echo sprint() over printf()?

stklcode commented 5 months ago

No, there is no benefit in generating a formatted string and echoing the output immediately.

There is a marginal difference from the outside: