[I18n] Add JavaScript i18n, typo and brand names

pluginkollektiv / statify

Statify – statistics plugin for WordPress

https://wordpress.org/plugins/statify/

GNU General Public License v3.0

76 stars 22 forks source link

[I18n] Add JavaScript i18n, typo and brand names #280

Closed pedro-mendonca closed 4 months ago

pedro-mendonca commented 9 months ago

This PR includes the following:

[x] Add JavaScript i18n to proper deal with JavaScript strings, including plurals, variables, etc
[x] Fix ~statify~ Statify brand name
[x] Typo

stklcode commented 9 months ago

Thanks Pedro!

I think we should add wp-i18n to the JS dependencies explicitly. On the dashboard it should be present anyway, so it works without, but relying on that is probably not best practice, is it?`

https://github.com/pluginkollektiv/statify/blob/83a29f1ab18e3df5b9a964b417e234431e2b83ff/inc/class-statify-dashboard.php#L126-L132

ping #253 for another WP 5.0+ argument

sonarcloud[bot] commented 4 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

pedro-mendonca commented 4 months ago

@stklcode I've added the wp-i18n core script to the dependencies as you've requested. Thanks for the review :)