pluginpal / strapi-plugin-config-sync

:recycle: CLI & GUI for continuous migration of config data across environments
https://www.pluginpal.io/plugin/config-sync
MIT License
255 stars 37 forks source link

The screen does not update when we import settings #110

Closed robsonpiere closed 1 year ago

robsonpiere commented 1 year ago

Bug report

Describe the bug

After importing the data, the screen still shows the same data to import.

Steps to reproduce the behavior

  1. Go to Config Sync interface menu
  2. Click on Import content types configs
  3. The data is updated on database, but not in screen.

Expected behavior

The imported files should disappear from the list without needing to restart the application.

Screenshots

error-plugin

Code snippets

N/A

System

Additional context

In console you can see Use Query Engine API instead of Entity Service API for type core-store

boazpoolman commented 1 year ago

Can you confirm this issue isn’t introduced since version 1.2. You can do that by explicitly installing version 1.1.3 and seeing if the problem still occurs

robsonpiere commented 1 year ago

Can you confirm this issue isn’t introduced since version 1.2. You can do that by explicitly installing version 1.1.3 and seeing if the problem still occurs

@boazpoolman I tested today on versions 1.1.3 and 1.2.0

In version 1.2.0 the error occurs. In version 1.1.3 the error does not occur.

boazpoolman commented 1 year ago

I'm seeing another issue (#109), also happening since 1.2.0 and I think they might be caused by the same problem. I've attempted to fix that by doing some changes in this PR #111.

Could you test that out to see if it solves this issue aswell?

You can install the PR like so:

yarn add boazpoolman/strapi-plugin-config-sync#pull/111/head
robsonpiere commented 1 year ago

@boazpoolman In this version

I no longer see the Use Query Engine API instead of Entity Service API for type core-store message in the console.

After importing the configuration, I see that the configuration was imported, but the file still appears in the list with changes to the id, createdAt and UpdatedAt fields, removing them from the configuration.

Restarting the application the difference disappears

Diff before import

image

Diff after import

image

Diff after restart:

image

boazpoolman commented 1 year ago

Thanks for testing the PR @robsonpiere

I was able to replicate the issue by manually updating a config file and then importing. This issue only happend for me with core-store.plugin_content_manager_configuration_content_types..... config files. I've also confirmed that this issue has been introduced in version 1.2.0 as downgrading to 1.1.3 fixes the issue for me.

Sadly the PR doesn't provide a solution for this problem. Currently investigation solutions.

boazpoolman commented 1 year ago

I've attempted to fix this issue in PR #113.

Could you test that fix on your end? You can install the PR like so:

yarn add boazpoolman/strapi-plugin-config-sync#pull/113/head
robsonpiere commented 1 year ago

I tested it and now it's ok! 🎉

I just see a message in the console, but I get no error.

[strapi-plugin-config-sync]: Use Query Engine API instead of Entity Service API for type core-store

MSACC commented 1 year ago

Fixed in https://github.com/boazpoolman/strapi-plugin-config-sync/pull/113

AliKdhim87 commented 1 year ago

I believe the issue remains unresolved since a new patch hasn't been released yet.

boazpoolman commented 1 year ago

You're correct. I've re-opened. Can be closed as soon as it's been released.

boazpoolman commented 1 year ago

The fix has been released with v1.2.2

If you're still having this, or any other issue with the plugin beyond v1.2.2 please feel free to open a new issue.