pluginpal / strapi-webtools

πŸ”— Unique, flexible and autogenerated URLs for your Strapi managed web content.
https://www.pluginpal.io/plugin/webtools
MIT License
34 stars 14 forks source link

feat: adding spanish and turkish translations #151

Closed SalahAdDin closed 3 months ago

SalahAdDin commented 5 months ago

What does it do?

It adds Spanish and Turkish translations for Core and Sitemap addon.

Why is it needed?

Spanish and Turkish speakers will require this.

How to test it?

Manually on the admin.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

changeset-bot[bot] commented 5 months ago

πŸ¦‹ Changeset detected

Latest commit: b474a84ef163bfec63f7cd4d0a6495842e87555b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages | Name | Type | | ----------------------------------- | ----- | | @pluginpal/webtools-addon-sitemap | Major | | @pluginpal/webtools-core | Minor | | @pluginpal/webtools-addon-menus | Major | | @pluginpal/webtools-addon-redirects | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

SalahAdDin commented 5 months ago

@boazpoolman how can I do that?

boazpoolman commented 5 months ago

https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md

SalahAdDin commented 5 months ago

https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md

Done!

SalahAdDin commented 5 months ago

For the core package, you must register the new translations manually. You can do that here:

https://github.com/pluginpal/strapi-webtools/blob/d683cd5ab265433e2e81118ddd28629657c23270/packages/core/admin/index.ts#L95

Afterwards we’re ready to get this merged!

Done!

SalahAdDin commented 4 months ago

@boazpoolman Why are the tests failing?

boazpoolman commented 4 months ago

Seems to be because of inability to upload the coverage files to codecov

SalahAdDin commented 4 months ago

Seems to be because of the inability to upload the coverage files to codecov

how can I fix it?

boazpoolman commented 4 months ago

Nothing you can do about it. We need to add an authentication key to make it work again.

SalahAdDin commented 3 months ago

Finally!