pluginsGLPI / formcreator

GLPI Plugin Formcreator (DOWNLOAD : https://github.com/pluginsGLPI/formcreator/releases)
http://www.teclib-edition.com
GNU General Public License v3.0
174 stars 125 forks source link

"Subtree root" option no longer exists [Form 2.12.1] #2395

Closed phamorais closed 3 years ago

phamorais commented 3 years ago

Describe the bug The "Subtree root" option for "Dropdown - ITIL CATEGORIES" type questions is not displayed

When using the form with version 2.11, the option was presented as the image below

image

However, when using version 2.12.1 the option does not appear as expected

image

Note: I noticed that in a new installation, the problem did not occur, nor did it affect the old forms that have this option

Old form (Simplified interface)

image

But when going in the form settings, the option of "Subtree root" doesn't appear either

image

Expected behavior When selecting a category, the option 'Subtree root' is expected to appear

Nothing relevant is displayed in php-errors.log

But I have this on console on Google Chrome

image

btry commented 3 years ago

Hi

Try the branch support/2.12.0 : if I remember well, this is already fixed.

btry commented 3 years ago

I did a quick check : the bug should be fixed in the latest revision of support/2.12.0

phamorais commented 3 years ago

@btry hi!

Can you tell me which specific commit? So I can test and validate it for you. Would it be this one? https://github.com/pluginsGLPI/formcreator/commit/ef3fc6623cfb2b9a1ebc7d6889179d895f2a0852

btry commented 3 years ago

Hi

I don't find the commit right now. Just check if the bug disappears with the latest revision.

HEre is a screenshot of che curent state of support/2.12.0

image

phamorais commented 3 years ago

@btry Hi!

I cloned the branch and apparently the problem is fixed. As the report of this issue is in my production environment, I'll have to look for the commit you made to fix this specific error.

btry commented 3 years ago

Unfortunately I don't have enough time to search for the commit. But be aware that pending bugfixes will be delivered tomorrow with the release 2.12.2.

By the way, if you validate the alternative to your PR I submitted today, I may have time to include it in the release as well.

phamorais commented 3 years ago

@btry

Thanks for the info. I'll wait for release 2.12.2.

Updated issue https://github.com/pluginsGLPI/formcreator/issues/2366 I ran the tests, it worked correctly with your fix https://github.com/pluginsGLPI/formcreator/pull/2398/files

btry commented 3 years ago

Great, then I close this issue.

phamorais commented 3 years ago

@btry

Hi! After upgrading to version 2.12.2 I noticed that in some forms the error still persists :(

I created a dev environment to analyze.

In the DEV environment, with a specific form, see the options appear

image

However, in my production environment the field still does not appear :(

In console Chrome, i got this : "mydomain.com/plugins/formcreator/ajax/commontree.php?itemtype=ITILCategory&root=15&maxDepth=1&selectableRoot=0"

image

Do you know what it can be?

Note: I was unable to reopen the issue

btry commented 3 years ago

The error is an attempt to download a resource which does not exists. I know this problem, but I did not find where it comes from. As it does has any negative impact, you can ignore this bug safely.