Icons swapped in formcreator 2.13.0-beta.2 in simplified interface GLPI 10

[bolivarf]

Forms that come without icons from older versions of formcreator have the fa-question-circle icon and FAQs have the fa-clipboard-list icon should be the other way around.

To Reproduce Steps to reproduce the behavior: 1 Create three forms for a category of frequently asked questions, the first since it could not be imported from previous schemes, just give it a title, faq category and export, edit the file and eliminate the fields "icon":0,"icon_color":"", "background_color":"", deleting the current form, import it again. The second just give it a title and the third change the icon 2 Create a FAQ in the category used by the forms

4. See error in simplified interface -> forms

Expected behavior That the forms without previous icons have the icon of fa-clipboard-list or the icon fa-edit or neither and the FAQ the icon of fa-question-circle like the rest of GLPI

Screenshots result

expected

GLPI / Plugins (please complete the following information):

• GLPI 10.0.1 formcreator Name: Form Creator Version: 2.13.0-beta.2 State: Enabled gantt Name: gantt Version: 1.0.0 State: Not installed glpiinventory Name: GLPI Inventory Version: 1.0.0 State: Installed / not activated mreporting Name: Más Informes Version: 1.8.0 State: Installed / not activated telegrambot Name: TelegramBot Version: 3.0.0 State: Not installed

Desktop (please complete the following information):

• OS: UBUNTU 22.04
• Browser Google Chrome
• Versión 102.0.5005.61 (Build oficial) (64 bits)

[btry]

Hi

A fix has been merged this week, fixing a problem when forms are displayed instead of faq, in separated KB mode. It may help to solve this issue. Can you test the latest revision of the branch support/2.13.0 ?

[bolivarf]

hi no problem i can try that branch

[bolivarf]

hello what is the branch is this https://github.com/pluginsGLPI/formcreator/tree/support/2.13.0

[bolivarf]

It says that it is 2.13.0-beta.2 and when it is active it does not appear in the simplified interface as if it were deactivated

[btry]

Check the status in the plugins page. If it ask you to run composer or yarn then you must do it. If you don't know these tools, then wait next week, i'll provide yo you a build

[bolivarf]

Loading composer repositories with package information Updating dependencies Nothing to modify in lock file Installing dependencies from lock file (including require-dev) Nothing to install, update or remove Package container-interop/container-interop is abandoned, you should avoid using it. Use psr/container instead. Package patchwork/jsqueeze is abandoned, you should avoid using it. No replacement was suggested. Generating optimized autoload files 31 packages you are using are looking for funding. Use the composer fund command to find out more!

[bolivarf]

yarn install v1.22.19 [1/4] Resolving packages... success Already up-to-date. Done in 0.36s

[bolivarf]

Composer version 2.3.6 2022-06-01 21:57:13

[bolivarf]

copy the vendor folder from the old plugin and run composer again, the plugin works in the normal interface but does not appear in the simplified interface.

composer install --no-dev Installing dependencies from lock file Verifying lock file contents can be installed on current platform. Package operations: 0 installs, 2 updates, 0 removals

• Upgrading symfony/polyfill-php80 (v1.23.1 => v1.26.0): Extracting archive
• Upgrading symfony/finder (v4.4.30 => v4.4.41): Extracting archive Package container-interop/container-interop is abandoned, you should avoid using it. Use psr/container instead. Package patchwork/jsqueeze is abandoned, you should avoid using it. No replacement was suggested. Generating optimized autoload files 3 packages you are using are looking for funding. Use the composer fund command to find out more!

[bolivarf]

GLPI's Helpdesk

Service catalog simplified

Service catalog extended

It doesn't seem to work in GLPI's Helpdesk mode, the other two modes I don't see the difference.

[btry]

In glpi helpdesknmode, formcreator does not changes the menus of GLPI (there were changes unti beta 1 or 2, then reverted back to behaviour of 2.12.0. some people were disturbed by that.

Simplified and extended service catalog differ only when displaying tickets. One show essential info, the other shows more.

Then the plugin is active and seems to work well as far as I see.

[bolivarf]

in previous versions the menu does not change but there is a new menu that called the forms here there is no way to use a form

[bolivarf]

old glpi

[btry]

In gkpi helpdesknmode you don't have access to forms (this is the regular solicited interface). Forms are accessible from normal interface, in assistance > forms.

In service catalog, click on "seek assistance".

I'm not having a computer right now then I answer using my memory, then I might be inaccurate about some minor things.

[bolivarf]

the problem is not the normal interface, it is the simplified one because there are users who do not have privileges for the normal interface and must be able to fill out forms as they could in previous versions of GLPI from 0.x.x to 9.x.x

[btry]

Ah yes ! I got the point.

I'll do a fix next week.

[bolivarf]

OK thank you so much

[bolivarf]

anyway it seems that they are using some libraries that are no longer supported

[btry]

Hi

Here is a fix for the menu entry: 5a07a70c066039d8c160608ce23077d96afc5bb5

[btry]

and an other to un-swap the icons: 42a45579

[bolivarf]

Hi The icons are fine, the name of the menu does not convince me much, but it could be fine.

[bolivarf]

For me this would make more sense, but it's just my opinion, I don't know what others may think .

[btry]

Hi

I agree, I'll change it to "Forms" like it was in 2.12.

commit: 07d27926

[bolivarf]

Hi and thanks The icon should also change based on the menu title, maybe not the one I put in the screenshot example, but something that better represents forms.

[btry]

Forms are used to fill a request for assistance or declare an incident. A headset icon has been selected because it is used in GLPI (10) for ticketing (see screenshot below).

[bolivarf]

ok I understand, thanks.

[bolivarf]

Although in the support menu of the normal view, the form option has another icon.

[btry]

Here ?

[bolivarf]

Yes, there should be no consistency.

[btry]

In this case forms are one of several possibilities (tickets, changes, ..., forms). This is a menu item, not a menu. It is bettter to have a more specialized icon as the headset is already used in the higher level.

[bolivarf]

Ok it's fine

[bolivarf]

You might also think there are other assistance options.

[btry]

Which context for this screenshot ? Self service with service catalog disabled ?

[bolivarf]

It is for end users, they can request services, they can see frequently asked questions, they can get answers to common problems or they can make requirements for which they have to fill out forms, some of these forms need approval as privileges to access a program and these being Homologated can create one or more cases, they can request equipment on loan. There is also a second level of users who, without being technology users, can provide services such as human resources personnel who can switch between their basic user profile and support user to meet requirements, for example, some type of registration by the which other user should fill out a form with the requested requirements

[btry]

HI

This does not helps me. I guess this is a self service with service catalog disabled. Do you confirm ?

[bolivarf]

if you mean the formcreator mode in the entity it is HelpDesk, if you mean the view it is simplified view

[bolivarf]

[btry]

OK.

In this mode we need to maintain access ti ticket creation along access to forms.

In this case, "seek assistance" is not appropriate as it would confuse with "Create ticket".

In short : "seek assistance should show only when it is tie only way to create a request (of any type).

[bolivarf]

that's correct

[bolivarf]

There is one feature that I came up with for the formcreator and that is forms without answers, only targets could work as a way to replace creating custom tickets, cases or problems.

[btry]

Open a new issue to discuss about that. Follow the rule 1 topic or bug = 1 issue.

[bolivarf]

sorry, you're right

[btry]

Hi

Are the issues with menus solved ? Can I close ?

[bolivarf]

Yes, thank you very much, it's solved.