pluginsGLPI / formcreator

GLPI Plugin Formcreator (DOWNLOAD : https://github.com/pluginsGLPI/formcreator/releases)
http://www.teclib-edition.com
GNU General Public License v3.0
174 stars 125 forks source link

Issue with Pending Forms List Showing Approved Forms as Pending #3363

Open edmenn opened 1 year ago

edmenn commented 1 year ago

Describe the bug When accessing the list of forms pending validation, many forms are displayed as pending even though they have already been approved. I believe the issue arises when the validator is set as a group rather than an individual user.

To Reproduce Steps to reproduce the behavior:

  1. Create a form that must be validated for a group of more than one user.
  2. fill the form
  3. enter and approve the form
  4. Navigate to the list of forms pending validation.
  5. Observe that some forms, which have already been approved, are still marked as pending.
  6. Check the validator for these forms and note that they are set as a group of more than one person.

Expected behavior Once a form has been approved, it should no longer appear in the list of forms pending validation, regardless of whether the validator is an individual or a group.

Screenshots image

GLPI / Plugins (please complete the following information):

Desktop (please complete the following information):

Actual Behavior: Forms that have been approved by a group validator still appear as pending in the list.

Additional Information: The issue seems to be specifically related to forms where the validator is set as a group of more than one person.

btry commented 1 year ago

Hi

Please show the URL of this page. You may redact the domain name if needed.

edmenn commented 1 year ago

Hi

Please show the URL of this page. You may redact the domain name if needed.

http://correcciones1c.sodru.com/plugins/formcreator/front/formanswer.php?criteria[0][link]=AND&criteria[0][field]=8&criteria[0][searchtype]=equals&criteria[0][value]=101

it is installed on a local server. Does not work externally

image

edmenn commented 1 year ago

Hi Please show the URL of this page. You may redact the domain name if needed.

http://correcciones1c.sodru.com/plugins/formcreator/front/formanswer.php?criteria[0][link]=AND&criteria[0][field]=8&criteria[0][searchtype]=equals&criteria[0][value]=101

it is installed on a local server. Does not work externally

image

ID: 166 from the image above, the historical shows that user Valiente Ana already approves it

image

btry commented 1 year ago

I don't want to access your glpi. I want to identify the type of the list you show in the screenshot, because most admins confuse the types of objects shown by the plugin. The URL will help me to do this. At least the part after the root web directory of glpi.

edmenn commented 1 year ago

Understood. The address is correct, only shows forms with status 101 (pending)

btry commented 1 year ago

Hi

I did a check with the latest revision of Formcreator 2.13 (it incluses unreleased bugfixes) and version 2.13.7. I could not reproduce.

When I approve a form answer, the status is updated in the form answer and also in the issue (as expected).

I noticed you did not specified the version of Formcreator. If you're using a version older than 2.13.7, please upgrade end check if the issue persists.

edmenn commented 1 year ago

HI

I'm with 2.13.7 version: Maybe I did not mention, but I have a group of two members as validators. If I configure only one person as a validator it works fine, but we need more than one.

image