pluginsGLPI / formcreator

GLPI Plugin Formcreator (DOWNLOAD : https://github.com/pluginsGLPI/formcreator/releases)
http://www.teclib-edition.com
GNU General Public License v3.0
174 stars 125 forks source link

Validator have no permission to validate a ticket generated from a multiple targets form in simplified interface #3416

Open fabriceverkor opened 11 months ago

fabriceverkor commented 11 months ago

Describe the bug Validator have no permission to validate a ticket generated from a multiple targets form in simplified interface To Reproduce Steps to reproduce the behavior:

  1. Send a approval request to user in such a ticket
  2. Validator clicks on link in received notification mail
  3. When using simplified interface, he get "You don't have permission to perform this action" message

When connected to standard interface (with technician profile), he's able to validate

When an approval is sent from a ticket generated by a form which has a single target, Validator is able to validate from simplified interface

In glpi_plugin_formcreator_issues, the difference is the itemtype : PluginFormcreatorFormAnswer when generated from multiple targets form, Ticket otherwise. When connected in simplified interface, the link in notification mail https://glpi.vic.verkor.com/front/ticket.form.php?id=9611&forcetab=Ticket$1 is redirected to https://glpi.vic.verkor.com/marketplace/formcreator/front/issue.form.php?id=179281&tickets_id=9611

When connected in standard interface, there is no redirection.

Expected behavior Any validator should be able to validate from simplified interface

GLPI / Plugins (please complete the following information):

Desktop (please complete the following information):

btry commented 11 months ago

Hi

Please show the URL found in the notification email, and the URL displayed in the browser after clicking on it (I expect that the URL changes due to some redirections).

You may redact the domain name.

btry commented 11 months ago

OK, I see you already provided the 2 link.

I think there is a need to enhance the redirection code in the plugin.

fabriceverkor commented 10 months ago

I would say that it's a bug, not an enhancement request. Self-Service user should be able to validate tickets when they are requested in all cases.

fabriceverkor commented 7 months ago

Any idea what should be done ? This behavior difference creates confusion. I have to add technician profile to validators of such tickets just to give them the ability to vaildate and explain them they have to switch to this profile. It does not make sense. Do you see another less confusing way ? I could not test but i guess the problem may be the same for observors who have only self-service profile.