pluginsGLPI / formcreator

GLPI Plugin Formcreator (DOWNLOAD : https://github.com/pluginsGLPI/formcreator/releases)
http://www.teclib-edition.com
GNU General Public License v3.0
174 stars 125 forks source link

ITIL Categories on ticket titles displaying > instead of > #3434

Open PMIBR opened 11 months ago

PMIBR commented 11 months ago

Describe the bug ITIL Categories on ticket titles displaying > instead of >

To Reproduce Steps to reproduce the behavior:

  1. Create form containing ITIL Category as one of the questions;
  2. Add a "create ticket" target;
  3. On the title, set it to ##answer_x## (i.e. the answer to the ITIL Category question);
  4. Create ticket using form;
  5. See error in ticket title.

Expected behavior Title being shown as "Category > Sub-category > Sub-category"... Instead, it is shown as "Category > Sub-category > Sub-category". >s inserted manually on the target ticket title still work, just ##answer_x## does not. Answers outside of the title (i.e. on the ticket body) work as intended.

Screenshots image image

GLPI / Plugins (please complete the following information):

Full plugin list on bottom of issue

Desktop (please complete the following information):

However, it happens on other machines with other OSes and browsers as well.

Additional context This bug was not present on formcreator version 2.13.5, so it's probably a regression bug introduced in a version after that one. Please let me know if more information is needed, and I'll be glad to assist.

Full plugin list

    news                 Name: Alertas                        Version: 1.12.1     State: Enabled                                 
        Install Method: Marketplace
    archibp              Name: Business Processes             Version: 1.0.14     State: Not installed                           
        Install Method: Marketplace
    camerainput          Name: Camera barcode                 Version: 2.0.2      State: Not installed                           
        Install Method: Marketplace
    fields               Name: Campos adicionais              Version: 1.21.6     State: Enabled                                 
        Install Method: Marketplace
    screenshot           Name: Captura de tela                Version: 2.0.2      State: Installed / not activated               
        Install Method: Marketplace
    behaviors            Name: Comportamentos                 Version: 2.7.2      State: Enabled                                 
        Install Method: Manual
    printercounters      Name: Contadores de impressora       Version: 2.0.0      State: Not installed                           
        Install Method: Marketplace
    accounts             Name: Contas                         Version: 3.0.3      State: Not installed                           
        Install Method: Marketplace
    archidata            Name: Data structures                Version: 1.0.13     State: Not installed                           
        Install Method: Marketplace
    escalade             Name: Escalonamento                  Version: 2.9.2      State: Enabled                                 
        Install Method: Marketplace
    formcreator          Name: Form Creator                   Version: 2.13.8     State: Enabled                                 
        Install Method: Marketplace
    gantt                Name: gantt                          Version: 1.0.4      State: Not installed                           
        Install Method: Marketplace
    gappessentials       Name: Gapp Essentials                Version: 2.1.2      State: Not installed                           
        Install Method: Marketplace
    order                Name: Gerenciamento das ordens de co Version: 2.10.4     State: Not installed                           
        Install Method: Marketplace
    tag                  Name: Gerenciamento de Etiquetas     Version: 2.11.7     State: Enabled                                 
        Install Method: Marketplace
    glpiinventory        Name: GLPI Inventory                 Version: 1.3.4      State: Enabled                                 
        Install Method: Marketplace
    mod                  Name: GLPI Modifications             Version: 2.0.2      State: Not installed                           
        Install Method: Manual
    itilcategorygroups   Name: Grupos ItilCategory            Version: 2.5.1      State: Not installed                           
        Install Method: Marketplace
    datainjection        Name: Importação de dados            Version: 2.13.4     State: Installed / not activated               
        Install Method: Marketplace
    pdf                  Name: Imprimir em PDF                Version: 3.0.0      State: Enabled                                 
        Install Method: Marketplace
    karastock            Name: Karastock                      Version: 1.4        State: Not installed                           
        Install Method: Manual
    timelineticket       Name: Linha do tempo dos chamados    Version: 10.0+1.1   State: Not installed                           
        Install Method: Marketplace
    moreticket           Name: Mais Chamados                  Version: 1.7.3      State: Enabled                                 
        Install Method: Marketplace
    mreporting           Name: Mais Relatórios                Version: 1.8.5      State: Enabled                                 
        Install Method: Marketplace
    satisfaction         Name: Mais satisfação                Version: 1.6.2      State: Enabled                                 
        Install Method: Marketplace
    metademands          Name: Meta-Demands                   Version: 3.2.19     State: Installed / not activated               
        Install Method: Marketplace
    metabase             Name: Metabase                       Version: 1.3.3      State: Enabled                                 
        Install Method: Marketplace
    mydashboard          Name: Meu Painel                     Version: 2.1.5      State: Installed / not activated               
        Install Method: Marketplace
    notifications        Name: Notifications                  Version: 9.5+1.0    State: Not installed                           
        Install Method: Manual
    onetimesecret        Name: OneTimeSecret                  Version: 2.0.0      State: Not installed                           
        Install Method: Marketplace
    additionalalerts     Name: Outros alertas                 Version: 2.4.0      State: Installed / not activated               
        Install Method: Marketplace
    dashboard            Name: Painel                         Version: 1.0.2      State: Enabled                                 
        Install Method: Manual
    consumables          Name: Pedidos de consumíveis         Version: 2.0.1      State: Installed / not activated               
        Install Method: Marketplace
    purchaserequest      Name: Purchase request               Version: 3.0.1      State: Not installed                           
        Install Method: Marketplace
    stab                 Name: Split Timeline Action Buttons  Version: 1.1.3      State: Installed / not activated               
        Install Method: Marketplace
    geststock            Name: Stock gestion                  Version: 2.1.0      State: Installed / not activated               
        Install Method: Manual
    taskdrop             Name: TaskDrop                       Version: 2.0.0      State: Installed / not activated               
        Install Method: Marketplace
    vip                  Name: VIP                            Version: 1.8.2      State: Not installed                           
        Install Method: Marketplace
TR0LLL commented 11 months ago

Hi, I had the same problem after upgrading to the latest version of formcreator. Did you get a solution?

PMIBR commented 11 months ago

Hi, I had the same problem after upgrading to the latest version of formcreator. Did you get a solution?

Sadly not, I'm not an experienced programmer, nor do I have a development environment to try and fix this. If I were to guess, it'll be either commit #6ce71f95 or #1b71d652 that re-introduced the bug, since they're the only commits related to escaping/sanitization post-2.13.5 afaik (the latter of which pertains to ticket title specifically).

However, do take this with a grain of salt, it's just a guess which I am unable to test.

TR0LLL commented 10 months ago

Hello, I still have the same problem here, did you manage to solve it?

TR0LLL commented 6 months ago

Today I updated my GLPI to 10.0.15 and formcreator version 2.13.9 and the error still persists =\ Any light to help us solve this? @btry

btry commented 6 months ago

Hi

The issue seems simple to solve, but I could not find a reliable fix for that (those found so far broke something else in the plugin). As the plugin reached end of life, I'l much less available for this kind of time consuming (and hopefully low impacting) issues. Please be patient and wait for GLPI 10.1 which will implement native forms.

PMIBR commented 6 months ago

Thanks for the reply! Yes, it's a low impact issue, so no problem with it staying as it is. Waiting for GLPI 10.1 then!