pluginsGLPI / ocsinventoryng

Plugin ocsinventoryng for GLPI
GNU General Public License v2.0
68 stars 52 forks source link

extra processor gets added on every sync #308

Open jackburton79 opened 2 years ago

jackburton79 commented 2 years ago

Plugin version 1.7.2 GLPI Version 9.5.7

Every time I sync a computer from OCSInventory-NG to glpi, it gets a new "processor" entry. Example: This computer was synchronized three times: image

If I do a full sync, the extra processors go away.

The processors are the same image image image

In OCSInventory there is only one processor image

Mirkk commented 2 years ago

I have the same issue, for both processors and Memory. The new entries appear each time that there was a Sync of the OCS agent. If you just press "syncronize" multiple times it doesn't happen. It happens only on some computers (around 10%, and then, always on the same ones) but I was not able to find any regularity, however most of them are servers with lots of devices and software (Win + Linux). It does not happen with client computers.

tsmr commented 2 years ago

Can you try with last bug-fixes version ? https://github.com/pluginsGLPI/ocsinventoryng/archive/refs/heads/9.5/bugfixes.zip

Mirkk commented 2 years ago

Thank you very much Xavier! I will test it tomorrow (and then it will take some days to evaluate if the issues persist). I saw that this is version 1.7.4 and that you did backports of various bugfixes done in v.2.0. (possibly also the domains fix I hope :-) ) Can you tell when 1.7.4 will be released officially? merci!

jackburton79 commented 2 years ago

I just installed this version. Will test in the next few data. Thank you!

Il mer 16 mar 2022, 11:08 Xavier CAILLAUD @.***> ha scritto:

Can you try with last bug-fixes version ? https://github.com/pluginsGLPI/ocsinventoryng/archive/refs/heads/9.5/bugfixes.zip

— Reply to this email directly, view it on GitHub https://github.com/pluginsGLPI/ocsinventoryng/issues/308#issuecomment-1068948694, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2W3T4KSLDDSD2C5E6DIJLVAGXJFANCNFSM5NLXANGA . You are receiving this because you authored the thread.Message ID: @.***>

jackburton79 commented 2 years ago

At a first glance this version seems to work and doe not duplicate elements. Will confirm in a couple of days.

Mirkk commented 2 years ago

Hi, I tested it, but I have an SQL error with full_sync when Unit_import is enabled for Software: Shouldn't the table be called softwares in inc/ocsdbclient.class.php ~#300?

Thank you!

MySQL query error: SQL: SELECT software_name.NAME, software_version.VERSION, software_publisher.PUBLISHER, software.COMMENTS, software.FOLDER, software.FILENAME, software.FILESIZE, software.SOURCE, software.HARDWARE_ID, software.GUID, software.LANGUAGE, software.INSTALLDATE, software.BITSWIDTH FROM software LEFT JOIN software_name ON (software.NAME_ID = software_name.ID) LEFT JOIN software_version ON (software.VERSION_ID = software_version.ID) LEFT JOIN software_publisher ON (software.PUBLISHER_ID = software_publisher.ID) WHERE software.HARDWARE_ID IN (198869) ORDER BY software.id DESC Error: Table 'ocsweb.software' doesn't exist

fgendorf commented 2 years ago

Hi Mirkk, on ocsweb database the table of softwares just called "software", so I think your problem is that all your ocsweb database is missing.


Frederico Gendorf

On Thu, Mar 17, 2022 at 7:37 AM Mirkk @.***> wrote:

Hi, I tested it, but I have an SQL error with full_sync when Unit_import is enabled for Software: Shouldn't the table be called softwares in inc/ocsdbclient.class.php ~#300 https://github.com/pluginsGLPI/ocsinventoryng/pull/300?

Thank you!

MySQL query error: SQL: SELECT software_name.NAME, software_version. VERSION, software_publisher.PUBLISHER, software.COMMENTS, software.FOLDER, software.FILENAME, software.FILESIZE, software.SOURCE, software. HARDWARE_ID, software.GUID, software.LANGUAGE, software.INSTALLDATE, software.BITSWIDTH FROM software LEFT JOIN software_name ON (software. NAME_ID = software_name.ID) LEFT JOIN software_version ON (software. VERSION_ID = software_version.ID) LEFT JOIN software_publisher ON ( software.PUBLISHER_ID = software_publisher.ID) WHERE software.HARDWARE_ID IN (198869) ORDER BY software.id DESC Error: Table 'ocsweb.software' doesn't exist

— Reply to this email directly, view it on GitHub https://github.com/pluginsGLPI/ocsinventoryng/issues/308#issuecomment-1070771861, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADSWPYGBDD3OOYB7EVKD5BDVAMDQPANCNFSM5NLXANGA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

tsmr commented 2 years ago

It depends on your OCS version. What's your version ?

Mirkk commented 2 years ago

Hi, I have OCS 2.7. Does the plugin in version 1.7.4 have different minimal requirements? Except the "software" it seems to work well.

Update: 1.7.0 works well, users the table "softwares". I see in the code that from 1.7.1 on it uses the table "software". Is the minimum OCS version written somewhere?

Thank you very much Mirko

tsmr commented 2 years ago

Yes you have the version defined on inc/ocsserver.class.php I had a fix. Can you try with last https://github.com/pluginsGLPI/ocsinventoryng/archive/refs/heads/9.5/bugfixes.zip

jackburton79 commented 2 years ago

At a first glance this version seems to work and doe not duplicate elements. Will confirm in a couple of days.

Confirm the problem is fixed. No more duplicating elements.

jackburton79 commented 2 years ago

I spoke too soon. The problem persists with this version.

tsmr commented 2 years ago

Hum..perhaps due to this condition https://github.com/pluginsGLPI/ocsinventoryng/blob/master/inc/device.class.php#L511

Mirkk commented 2 years ago

Hi @tsmr ! in this thread you gave us version 1.7.4, and I saw that it had various fixes, not only the one mentioned in this thread. When will it be released "officially"? Thank you!

David-Rodriguez-cabrera commented 1 year ago

For me, it deletes the old components and recreates the components every time I synchronize, and it doesn't matter if nothing has been changed in the asset. Import and link rules don't work on my glpi.

glpi version: 10.0.6 OCS version: 2.0.4 ocs-agent version: 2.9.2 Operating System: Windows