pluginsGLPI / ocsinventoryng

Plugin ocsinventoryng for GLPI
GNU General Public License v2.0
68 stars 52 forks source link

Missing Filesystem #327

Closed blippercop closed 2 years ago

blippercop commented 2 years ago

OCS is detecting ReFS that seems to be missing here.

https://github.com/pluginsGLPI/ocsinventoryng/blob/ec4dfabed9bfd8ac587a3c2efb4536f09f3fe7aa/inc/disk.class.php#L121

OCS DB: image

If the Filesystem is not detected properly it will lead to a missing $disk['name']. A missing $disk['name'] will lead to not executing the update bitlocker part (https://github.com/pluginsGLPI/ocsinventoryng/blob/ec4dfabed9bfd8ac587a3c2efb4536f09f3fe7aa/inc/disk.class.php#L177))

blippercop commented 2 years ago

Jup, its even worse. I am having searchalerts for drives with low storage from inventory but the ReFS drives are not appearing at all in the computerobject in GLPI because of that isue. So it is causing an incomplete inventory.

blippercop commented 2 years ago

@tsmr Thank you for that! However it is not working as it should be "ReFS" instead of the patch with "reFS" - the check seems to be case sensitive. Tested both.

blippercop commented 2 years ago

@tsmr You are a bit trolling me right 😅

Tested: reFS -> not working (two drives instead of four) REFS -> not working (two drives instead of four) ReFS -> working (four drives of four)

is must be exactly case sensitive - sorry to bother but this should fix a couple of things with the inventory

blippercop commented 2 years ago

Fixed by https://github.com/pluginsGLPI/ocsinventoryng/commit/9fb58e0972fd9da839fd733fd844454c6169b485

Thank you!