Add object into command without adding reference. see #77

[amma35]

Add object into command without adding reference.

It is possible to add a configuration for the use of free references so that it remains transparent for users who don't want it.

I didn't do the locales, but I can do them if I need to.

[amma35]

anybody? Is it possible to integrate this functionality in the plugin?

[orthagh]

Here is a first review.

Some general notices on the implementation:

• to avoid pandora's box open, it could be better to enable manually this feature by configuration.
• please set a new version (2.1 ?) in setup
• I can't convert Reference free lines to items, but i don't know, maybe it's ok

Bugs found:

• in split view (on a 1080 screen), if i ask to save the reference, the Add button disappears on the right of window
• after adding the line with reference, if an existing reference exist with the same name, error triggers and form data are lost
• adding license references doesn't seems to work, no errors show nor logs btw
• massive actions for reception of "Reference free" line doesn't work
• bulk action for reception of theses line works, but still displays an error (no Item selected)
• Bill tab triggers some php notices:

  2018-04-10 17:21:25 [377@LU002]
  *** PHP Warning(2): Missing argument 3 for PluginOrderOrder_Item::queryBills(), called in /var/www/html/glpi/9.2-git/plugins/order/inc/order_item.class.php on line 1457 and defined
  Backtrace :
  plugins/order/inc/order_item.class.php:565         
  plugins/order/inc/order_item.class.php:1457        PluginOrderOrder_Item->queryBills()
  plugins/order/inc/order_item.class.php:1361        PluginOrderOrder_Item->showBillsItemsDetail()
  plugins/order/inc/bill.class.php:574               PluginOrderOrder_Item->showBillsItems()
  inc/commonglpi.class.php:482                       PluginOrderBill::displayTabContentForItem()
  ajax/common.tabs.php:96                            CommonGLPI::displayStandardTab()
  2018-04-10 17:21:25 [377@LU002]
  *** PHP Notice(8): Undefined variable: tabRef
  Backtrace :
  plugins/order/inc/order_item.class.php:569         
  plugins/order/inc/order_item.class.php:1457        PluginOrderOrder_Item->queryBills()
  plugins/order/inc/order_item.class.php:1361        PluginOrderOrder_Item->showBillsItemsDetail()
  plugins/order/inc/bill.class.php:574               PluginOrderOrder_Item->showBillsItems()
  inc/commonglpi.class.php:482                       PluginOrderBill::displayTabContentForItem()
  ajax/common.tabs.php:96                            CommonGLPI::displayStandardTab()
  2018-04-10 17:21:25 [377@LU002]
  *** PHP Notice(8): Undefined variable: tabRef
  Backtrace :
  plugins/order/inc/order_item.class.php:594         
  plugins/order/inc/order_item.class.php:1457        PluginOrderOrder_Item->queryBills()
  plugins/order/inc/order_item.class.php:1361        PluginOrderOrder_Item->showBillsItemsDetail()
  plugins/order/inc/bill.class.php:574               PluginOrderOrder_Item->showBillsItems()
  inc/commonglpi.class.php:482                       PluginOrderBill::displayTabContentForItem()
  ajax/common.tabs.php:96                            CommonGLPI::displayStandardTab()

[amma35]

A first return:

• to avoid pandora's box open, it could be better to enable manually this feature by configuration.

• please set a new version (2.1 ?) in setup I added the configuration and created a new version

• I can't convert Reference free lines to items, but i don't know, maybe it's ok We haven't developed this feature because there is no object type.

• in split view (on a 1080 screen), if i ask to save the reference, the Add button disappears on the right of window Ok I fixed it

• after adding the line with reference, if an existing reference exist with the same name, error triggers and form data are lost The only way to get the values entered before the error message is to pass this to session variable that are not used in the plugin. Should I add this feature?

• adding license references doesn't seems to work, no errors show nor logs btw This problem arises with adding as an item of the command or generating as an associated items?

• massive actions for reception of "Reference free" line doesn't work I haven't reproduced this bug.

• bulk action for reception of theses line works, but still displays an error (no Item selected) I haven't reproduced this bug.

Is this the interface where the problem occurs?

• Bill tab triggers some php notices Indeed merge problem with the old version.

[cedric-anne]

Squashed and merged into develop (commit 32928dec999173ea7fa8924f42833012027222bb).