search

pluginsGLPI / room

Room GLPI plugin
GNU General Public License v2.0
16 stars 13 forks source link

GLPI 9.4 Compatibility #36

Closed kornelson closed 4 years ago

kornelson commented 5 years ago

Please, would you update the plugin to support GLPI 9.4 Thanks. Is a very usefull plugin. thanks.

ShkerzyA commented 5 years ago

Yeah, would you update your very usefull and important plugin to support GLPI 9.4. Many thanks to You

reinethernal commented 5 years ago

Indeed. Compatibility with 9.4 is really nessesary

jackburton79 commented 5 years ago

I installed on glpi 9.4.2 the alpha version 3.1.2, modified line 58 of rooms/setup.php from

if (version_compare(GLPI_VERSION, '9.3.1', '>=') && version_compare(GLPI_VERSION, '9.4', '<')) {

to

if (version_compare(GLPI_VERSION, '9.3.1', '>=') && version_compare(GLPI_VERSION, '9.5', '<')) {

and was able to use the plugin on that version. I haven't done extensive testing, yet, but it seems to work

I added PR #39. Could be improved, obviously.