search

pluginsGLPI / room

Room GLPI plugin
GNU General Public License v2.0
16 stars 12 forks source link

Glpi 9.5 compatibility #45

Closed jackburton79 closed 3 years ago

jackburton79 commented 4 years ago

Update plugin for glpi 9.5

Removed translations since they were made with a deprecated api. Added back italian and hungarian translation

jackburton79 commented 4 years ago

Hi, Thanks for the 9.5-code migration. As you can see I (finally) updated the plugin for GLPI 9.4 so I introduced a few conflicts. Can you please resolve them?

Done.

Also, don't bother upgrading plugin version in room.xml and setup.php: it's "handled" in the release process.

Ok, thanks.

jackburton79 commented 3 years ago

Do I need to change anything else, for this PR to be merged ?

C-Duv commented 3 years ago

Hello, I read the commits but didn't tested anything (I am really "out of GLPI" right now, as you can tell). Anyway it looks good to me and I can see your fork have been running for a while among multiple installations.

C-Duv commented 1 year ago

Just realized this merge occurred in master instead of develop :'(

jackburton79 commented 1 year ago

I have another PR on master, the one for GLPI 10. Should I redo it on develop ? Sorry I'm not very familiar with the policies here.