search

pluginsGLPI / room

Room GLPI plugin
GNU General Public License v2.0
16 stars 13 forks source link

UPDATE for 9.5+ #57

Closed EunirCarolino closed 1 year ago

EunirCarolino commented 2 years ago

Please! Update! Actual version doesnt work on glpi 9.5.5

jackburton79 commented 2 years ago

Hi! The released version does not work on glpi 9.5, indeed. The code from master branch works, though. You can get it by cloning the master branch of the git repository.

AdrianXuizGarcia commented 2 years ago

Hi! I dont think this works on 9.5.5 , im afraid... After installing, i can see the "Room" category, but when i enter, it shows the following error: PHP Notice (8): Trying to access array offset on value of type null in /var/www/glpi/plugins/room/hook.php at line 298 PHP Notice (8): Trying to access array offset on value of type null in /var/www/glpi/plugins/room/hook.php at line 299 Also i can create a new room, but cant choose any of the options (like Locations or Groups), and it throws another error when trying to save the new room (Invalid host in HTTP_REFERER)

(Trying the code from the @jackburton79 branch and the master, neither works)

jackburton79 commented 2 years ago

I'm currently using my branch in production on 9.5.7, and on a test installation of the 10.0 branch.

the glpi_9.5_compatibility branch from my repo works on 9.5.x, and the glpi-10 branch works on 10.0

AdrianXuizGarcia commented 2 years ago

That branch of your repo should work on 9.5.5, then? Cos thats the one ive been trying to make it work... And gives the error I commented before :( EDIT: At the end, the problem was mine: I had the debug activated, which doesnt allow to add new rooms. Once i turn off debug mode, and added a room, the others errors dissapeared. Thank you for your patience!

jcervantes-sipecom commented 2 years ago

Hi @jackburton79, I have downloaded and installed your version compatibility for 9.5, but there is a bug when uninstalled the plugin with a Room that have been activated a reservation, that cause a bug with another plugin, Reservation Plugin, please check this: https://github.com/salleman33/reservation/issues/64

jackburton79 commented 2 years ago

Will have a look

jackburton79 commented 2 years ago

I just pushed a change (on the glpi-10 branch) which should fix that problem. BEWARE! I just tested it briefly on my test installation, I RECOMMEND YOU to try it in a test environment to avoid losing reservations

jackburton79 commented 2 years ago

I also pushed on the 9.5 branch here: https://github.com/jackburton79/room/tree/glpi_9.5-fixes

jackburton79 commented 1 year ago

Closing since there has been a release which works on 9.5