fixes #17 fix opening credits start time

plugorgau / bbb-render

Scripts to convert a BigBlueButton recording into a single video file

MIT License

65 stars 25 forks source link

Open jmlich opened 2 years ago

jmlich commented 2 years ago

it seems opening credits was removed due to following condition:

        # Skip clips entirely before the start point
        if start + duration < self.start_time:
            return

Moving start time of opening credits helps

valerio-bozzolan commented 1 year ago

I tested this patch on my local computer and it just works as expected. Tried with:

./make-xges.py --opening-credits=intro-pepper.png asd presentation.xges

And it put my pepper in the intro as usual:

Screenshot_GIMP_pepper

I recommend in merging this.

(I'm not the maintainer)

valerio-bozzolan commented 4 months ago

Premising that I've done some code review, and I'm merging what I like in this fork:

Hoping to be useful, this pull request was merged in that fork, at this point: