search

plugowski / umenu

Menu generator for MicroPython
23 stars 6 forks source link

Error from example #1

Closed NamkingWIN closed 2 years ago

NamkingWIN commented 3 years ago

Hi I have run you example code in this repo but the error occur after reset my esp32 " umenu.py line 373 in draw umenu.py line 382 in item_line"

Please help me. Thanks.

plugowski commented 3 years ago

Hi,

Which example did you run? Simple menu or rotary?

NamkingWIN commented 3 years ago

Yeah the simple menu example. But I have to modificative your library for my purpose. Thank you.

johnr1245 commented 2 years ago

Hi I am having this same issue. Did you ever fix it? Author could you respond with a solution?

Thank you

plugowski commented 2 years ago

@johnr1245 Hi, sorry I forgot to take a look into it, but because recently I'm using my lib in one project I can confirm that it works, I will check example code and will go back to you pretty soon :)

plugowski commented 2 years ago

@johnr1245 okay yeah it was my fault, for example I wanted go by shortcut and use lambda as callable passed to constructor, and it didn't work as expected :P Please feel free to see updated code.

johnr1245 commented 2 years ago

Oh beautiful thank you so much for fixing!! Have enjoyed playing around a bit and going through umenu I was able to get some stuff fixed that were causing syntax errors. Should I just add the corrected lines to the`umenu.py' file?

plugowski commented 2 years ago

@johnr1245 you mean push some Pull Request? You can do that, actually I didn't found other problems here so far, so I can review your fixes :)

johnr1245 commented 2 years ago

Beautiful sounds good!! thank you! Also asked another question in a new issue and have mainly solved the switch issue but have some questions about reading from sd cards and creating proper submenus. thanks!