search

plugwise / Plugwise-Smile

Plugwise module for Smiles (Anna, Adam, P1)
MIT License
4 stars 3 forks source link

Remove heating = None #65

Closed bouwew closed 4 years ago

bouwew commented 4 years ago

Adds heating=None for all devices, was not the intention. Causes no issues in Plugwise-beta.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@92b899a). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #65   +/-   ##
=========================================
  Coverage          ?   93.01%           
=========================================
  Files             ?        4           
  Lines             ?     1231           
  Branches          ?        0           
=========================================
  Hits              ?     1145           
  Misses            ?       86           
  Partials          ?        0
Impacted Files Coverage Δ
Plugwise_Smile/Smile.py 92.61% <ø> (ø)
tests/test_Smile.py 96.54% <ø> (ø)
setup.py 0.00% <0.00%> (ø)
Plugwise_Smile/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 92b899a...61ba61a. Read the comment docs.

CoMPaTech commented 4 years ago

Just reverting?

bouwew commented 4 years ago

Yes, does not break Plugwise-beta, we initialize self.heating_state to None.