search

plugwise / Plugwise-Smile

Plugwise module for Smiles (Anna, Adam, P1)
MIT License
4 stars 3 forks source link

Pickle exporter for HA-core tests #70

Closed CoMPaTech closed 4 years ago

CoMPaTech commented 4 years ago

Work-in-progress, pickle exporter for HA-core testing (saving 900 kb from using xmls)

This PR aims to generate pickle files for HA-core testing of the integration. altough it will generate pickles for everything in tests the current PR for HA only uses 3 cases

codecov[bot] commented 4 years ago

Codecov Report

Merging #70 into master will decrease coverage by 0.00%. The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage   92.90%   92.90%   -0.01%     
==========================================
  Files           4        4              
  Lines        1241     1254      +13     
==========================================
+ Hits         1153     1165      +12     
- Misses         88       89       +1
Impacted Files Coverage Δ
Plugwise_Smile/Smile.py 92.41% <ø> (+0.13%) :arrow_up:
tests/test_Smile.py 96.35% <86.66%> (-0.28%) :arrow_down:
Plugwise_Smile/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c9e1266...9c69ebe. Read the comment docs.

CoMPaTech commented 4 years ago

Besides the removal of a pass (to ensure pylint) there is no functionality change for the module itself. If rc1 passes for the notification issues one of the users experienced we can safely release master to 1.0.1 afaic