search

plugwise / Plugwise-Smile

Plugwise module for Smiles (Anna, Adam, P1)
MIT License
4 stars 3 forks source link

Add self.hostname #80

Closed bouwew closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #80 into master will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   92.92%   92.94%   +0.02%     
==========================================
  Files           4        4              
  Lines        1258     1262       +4     
==========================================
+ Hits         1169     1173       +4     
  Misses         89       89
Impacted Files Coverage Δ
Plugwise_Smile/Smile.py 92.50% <100.00%> (+0.04%) :arrow_up:
Plugwise_Smile/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 034a8f9...2cc1e12. Read the comment docs.

CoMPaTech commented 4 years ago

Does this work across v2/v3?

bouwew commented 4 years ago

I think it should, due to all the added checks. Also, no zeroconf discovery for P1 v2 so safe to use the gateway_id. And we also need code as in https://github.com/plugwise/plugwise-beta/commit/b693577065995044547f3be673628ef4470a99bb

But, there's no gateway_id assigned for the P1 v2? See our private topic on Discord.

bouwew commented 4 years ago

Confirmed by Martin, the Smile P1 v2 does not support zeroconf discovery. So, add via Integrations --> + --> enter IP and password.

CoMPaTech commented 4 years ago

Looking good