plugwise / Plugwise-Smile

Plugwise module for Smiles (Anna, Adam, P1)
MIT License
4 stars 3 forks source link

Conflicting setup requirement with standard library for Python 3.7 / 3.8 #86

Closed MartinHjelmare closed 4 years ago

MartinHjelmare commented 4 years ago

Describe the bug

Evidence

(home-assistant) x:~/Dev/home-assistant/home-assistant$ pipdeptree -w silence --packages Plugwise-Smile
Plugwise-Smile==1.1.0
...
  - asyncio [required: Any, installed: 3.4.3]
  - datetime [required: Any, installed: 4.3]
    - pytz [required: Any, installed: 2020.1]
    - zope.interface [required: Any, installed: 5.1.0]
      - setuptools [required: Any, installed: 46.1.3]
...

Expected behavior Modules that are already available in the standard library should not be installed from PyPI to avoid conflicts.

Home Assistant Core (please complete the following information):

bouwew commented 4 years ago

@MartinHjelmare Noted, thanks!

Does this have a higher priority than the open Plugwise-related PR's? Meaning, should we fix this before these PR's are getting merged?

MartinHjelmare commented 4 years ago

This can be fixed separately, but it's probably a small change, so can be done quickly. I'm assuming you don't need the zope interface that the DateTime library on PyPI is using.

https://pypi.org/project/DateTime/

CoMPaTech commented 4 years ago

This can be fixed separately, but it's probably a small change, so can be done quickly. I'm assuming you don't need the zope interface that the DateTime library on PyPI is using.

https://pypi.org/project/DateTime/

Nope, rather without zope, thanks for pointing that out.

CoMPaTech commented 4 years ago

Not yet closed, still in beta-release waiting for release minor

CoMPaTech commented 4 years ago

@MartinHjelmare tested against dev just yet as well as for both open PRs from our side - looks like 1.3.0b13 is acceptable for HA but we are expecting results from our testers environments to be sure.

CoMPaTech commented 4 years ago

@MartinHjelmare home-assistant/core#39726 is merged, can you verify / can we close this one as well?

MartinHjelmare commented 4 years ago

Yes. Thanks!