bouwew commented 4 years ago

Changes:

add support for the P1 with firmware v2.1(.17)
read xml-data from /system/status.xml (should work for P1 with firmware v2.5)
for P1 provide hostname for use in plugwise-beta config_flow
improve/shorten code
update tests and testdata for above changes (only fixing stuff, no coverage increase)

codecov[bot] commented 4 years ago

Codecov Report

Merging #88 into master will increase coverage by 1.17%. The diff coverage is 88.57%.

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   91.69%   92.86%   +1.17%     
==========================================
  Files           4        4              
  Lines        1324     1317       -7     
==========================================
+ Hits         1214     1223       +9     
+ Misses        110       94      -16

Impacted Files	Coverage Δ
Plugwise_Smile/Smile.py	`91.97% <84.61%> (+2.06%)`	:arrow_up:
Plugwise_Smile/__init__.py	`100.00% <100.00%> (ø)`
tests/test_Smile.py	`96.59% <100.00%> (+0.03%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9932e88...5641aa1. Read the comment docs.

bouwew commented 4 years ago

Zullen we ook de wijzigingen voor 0.115 hierin meenemen?

plugwise / Plugwise-Smile

Read p1 status #88

Codecov Report