search

plugwise / Plugwise-Smile

Plugwise module for Smiles (Anna, Adam, P1)
MIT License
4 stars 3 forks source link

Remove direct objects #90

Closed bouwew closed 4 years ago

bouwew commented 4 years ago

In all relevant (test)cases the data taken from /core/direct_objects is available in /core/domain_objects, so let's not read /core/direct_objects from the Smiles.

codecov[bot] commented 4 years ago

Codecov Report

Merging #90 into master will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   92.87%   92.92%   +0.04%     
==========================================
  Files           4        4              
  Lines        1320     1300      -20     
==========================================
- Hits         1226     1208      -18     
+ Misses         94       92       -2
Impacted Files Coverage Δ
tests/test_Smile.py 96.56% <ø> (-0.04%) :arrow_down:
Plugwise_Smile/Smile.py 92.13% <100.00%> (+0.12%) :arrow_up:
Plugwise_Smile/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2004786...4069b6c. Read the comment docs.