Closed CoMPaTech closed 1 month ago
The recent changes enhance the configuration and linting rules for several files, notably improving the validation mechanisms in the YAML linting setup and the plugwise integration. Updates to the type checker and linting tool promote better coding practices, particularly with asynchronous programming. These refinements aim to ensure compatibility with upcoming Home Assistant versions, improving maintainability and code reliability.
Files | Change Summary |
---|---|
.yamllint |
Reduced minimum spaces in comments from 2 to 1; removed ignored pattern for Azure YAML files. |
custom_components/plugwise/config_flow.py |
Enhanced input validation for CONF_HOMEKIT_EMULATION from boolean to vol.All(cv.boolean) . |
mypy.ini |
Upgraded Python version to 3.12; changed import handling to normal; added new error codes; adjusted checks. |
pyproject.toml |
Restructured linting rules under [tool.ruff.lint] ; added rules for async practices; updated ignore list and alias mappings. |
Objective | Addressed | Explanation |
---|---|---|
Ensure compatibility with upcoming Home Assistant versions (#[691]) | ✅ | |
Enhance input validation for plugwise integration (#[691]) | ✅ |
🐰 Hopping through the code with glee,
New rules and checks for you and me!
Linting brightens our sunny day,
Async practices lead the way!
In Home Assistant, we trust and play! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Please retry analysis of this Pull-Request directly on SonarCloud
Merging ... looked at the sonarcloud error, but it's internal on their side with duplicate uuid's in their postgesql database :)
Fixes #691 mypy issue for beta (this part is not upstreamed) Follow upstream changes
Summary by CodeRabbit
New Features
Configuration Updates
Bug Fixes
Chores