plugwise / python-plugwise

Plugwise python module for Smiles (Anna, Adam, P1) and Stretch
https://pypi.org/project/plugwise
MIT License
10 stars 9 forks source link

Schedule-related improvements #558

Closed bouwew closed 3 months ago

bouwew commented 3 months ago

I realized that the thermostat-select for the legacy Anna only has one schedule-option. The Off-option was added so the select of the Plugwise HA integration works the same as for the non-legacy thermostats. Also, detection of an empty schedule was added.

Finally, a small correction was made for actual devices.

Furthermore, all in [..., ...] constructs were replaced by in (..., ...) constructs including one typing-item in constants.py: Final[list[str]] to Final[tuple[str, ...]]. And, some double used code was replaced by a common function, common_match_cases().

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (f72847c) to head (b31d57b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #558 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 20 20 Lines 3150 3138 -12 ========================================= - Hits 3150 3138 -12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.3% Duplication on New Code

See analysis details on SonarCloud