Don't output schedule-related data when no valid schedule(s) found

plugwise / python-plugwise

Plugwise python module for Smiles (Anna, Adam, P1) and Stretch

https://pypi.org/project/plugwise

MIT License

10 stars 9 forks source link

Don't output schedule-related data when no valid schedule(s) found #559

Closed bouwew closed 3 months ago

bouwew commented 3 months ago

When trying to implement v0.37.6 into plugwise-beta (Select-platform) I ran into a problem. I realized this was best fixed in the backend by not outputting the schedule(s) data when there is(are) no valid schedule(s) present. So this was implemented.

During this process I corrected the manual-fixture script, and some omissions in the legacy_anna data.

Please see https://github.com/plugwise/plugwise-beta/pull/644 for the corresponding changes in pw-beta.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (02802b3) to head (e449bd6).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #559 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 20 20 Lines 3138 3140 +2 ========================================= + Hits 3138 3140 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud