Add a reboot_gateway() funtion for actual Plugwise devices.

bouwew commented 5 months ago

Part of implementing https://github.com/plugwise/plugwise-beta/issues/604

Summary by CodeRabbit

Bug Fixes
- Improved handling and validation of POST request responses for more accurate error handling.
Chores
- Updated project version to 0.38.0 in configuration files.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (ba2668c) to head (1081c21).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #565 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 20 20 Lines 3151 3216 +65 ========================================= + Hits 3151 3216 +65 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bouwew commented 5 months ago

Test-coverage still required.

bouwew commented 5 months ago

@coderabbitai review

coderabbitai[bot] commented 5 months ago

Actions Performed

Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai[bot] commented 5 months ago

Walkthrough

The recent updates to the Plugwise project include refining the handling of POST requests in plugwise/helper.py by adjusting headers and data, as well as improving response validation logic. Additionally, the version in pyproject.toml has been incremented from "0.37.9" to "0.38.0".

Changes

Files	Change Summary
`plugwise/helper.py`	Added conditional handling for POST requests, adjusted headers/data, refined response validation logic.
`pyproject.toml`	Updated project version from "0.37.9" to "0.38.0".

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant PlugwiseHelper
    participant Server

    User->>PlugwiseHelper: Make POST request
    PlugwiseHelper->>PlugwiseHelper: Adjust headers and data
    PlugwiseHelper->>Server: Send POST request with adjusted headers/data
    Server-->>PlugwiseHelper: Response
    PlugwiseHelper->>PlugwiseHelper: Validate response
    PlugwiseHelper-->>User: Return validated response

Poem

In the code where data flows, A helper's wisdom gently grows. POST requests now refined with care, Headers adjusted, data fair. Version bumped, the future's bright, Plugwise shines in coding light. 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

bouwew commented 4 months ago

@coderabbitai review

coderabbitai[bot] commented 4 months ago

Actions performed

Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

CoMPaTech commented 4 months ago

Outside diff range and nitpick comments (1)
plugwise/helper.py (1)> Line range hint 145-145: Define the LOGGER variable.
+ from logging import getLogger
+ LOGGER = getLogger(__name__)
The LOGGER variable is used throughout the file but is not defined. This will cause a runtime error. Define LOGGER at the beginning of the file to fix this issue. Also applies to: 156-156, 179-179, 184-184, 190-190, 197-197, 648-648, 650-650
Review details