Add try-except constructs for all set-functions

bouwew commented 3 months ago

Summary by CodeRabbit

New Features
- Enhanced exception handling for various method calls to improve reliability.
- Introduced call_request() function for common exception handling.
Bug Fixes
- Updated test cases to handle ConnectionFailedError exceptions.
- Added assertions for specific test scenarios to ensure robustness.
Chores
- Updated project version to 0.38.1a0 in pyproject.toml.
- Documented changes and improvements in CHANGELOG.md.
Tests
- Improved test coverage and assertions for better error handling and validation.

coderabbitai[bot] commented 3 months ago

[!NOTE]

Reviews paused

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.

@coderabbitai review to trigger a single review.

[!WARNING]

Rate limit exceeded

@bouwew has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 59 seconds before requesting another review.

How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.

Commits
Files that changed from the base of the PR and between ea4411f984837b489c561f9772641c41baed8d7d and 4730acab9c4d6143d82312be340f73e88fdbc115.

Walkthrough

The recent updates primarily focus on enhancing exception handling across various modules, particularly within the plugwise package. The changes introduce a new call_request function to handle ConnectionFailedError exceptions uniformly. Additionally, corresponding test files have been updated to reflect these changes, ensuring robust error handling and improving overall code quality.

Changes

Files	Change Summary
`plugwise/__init__.py`	Added exception handling using `try-except` blocks for `_smile_api` method calls and introduced `call_request` function.
`plugwise/legacy/smile.py`	Introduced `call_request` method for `_request` with exception handling and updated method calls to use `call_request`.
`tests/test_adam.py`	Updated exception handling from `PlugwiseError` to `ConnectionFailedError` and added assertions for `tinker_max_boiler_temp`.
`tests/test_anna.py`	Modified `test_connect_anna_loria_heating_idle` to include additional calls and assertions for `tinker_dhw_mode`.
`tests/test_legacy_anna.py`	Added `skip_testing` argument to `device_test` method call in `test_connect_legacy_anna` function.
`CHANGELOG.md`	Documented the new exception handling, `call_request` function, and test code improvements for version `v0.38.1`.
`pyproject.toml`	Updated project version from `0.38.0` to `0.38.1a0`.

Poem

In code's vast and winding lane,
Errors now are tamed and plain,
With call_request to guard the gate,
Connection woes now dissipate.
Tests refined, exceptions caught,
In version 0.38.1, progress wrought.
A rabbit's joy, in bytes and code,
As Plugwise paths now smoothly flowed. 🐇💻

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

bouwew commented 3 months ago

@coderabbitai review

coderabbitai[bot] commented 3 months ago

Actions performed

Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (02990de) to head (4730aca).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #574 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 20 20 Lines 3219 3309 +90 ========================================= + Hits 3219 3309 +90 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bouwew commented 3 months ago

@coderabbitai ignore

CoMPaTech commented 3 months ago

@coderabbitai please approve, we'll check up on your recommendations at a later stage, outside of this PR

coderabbitai[bot] commented 3 months ago

@CoMPaTech, I've approved the PR as requested. Feel free to revisit the recommendations at your convenience later. If you need further assistance or have additional requests, just let me know!

Actions performed

Comments resolved and changes approved.