Closed bouwew closed 4 months ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
This update addresses Core Issue #119686 by making semantic changes to the set_number_setpoint
method in the Smile
class, ensuring appropriate handling of temperature setpoint keys. Additionally, the project version is bumped from 0.37.3 to 0.37.4 in pyproject.toml
. Log messages related to temperature adjustments in tests are also enhanced for clarity.
Files | Change Summary |
---|---|
CHANGELOG.md |
Documented the fix for Core Issue #119686 in version v0.37.4. |
plugwise/smile.py |
Modified the set_number_setpoint method to conditionally reassign the key parameter. |
pyproject.toml |
Updated project version from 0.37.3 to 0.37.4. |
tests/test_init.py |
Enhanced log messages in tinker_max_boiler_temp function to include specific test information. |
Propelled by lines of clever code,
The boiler's setpoint, now well-told,
A version bump, a seamless flow,
Logs enriched, more clarity to show.
Core Issue fixed, our quest a guide,
In 0.37.4, we stride with pride.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
11e81ae
) to head (66f7b95
).:exclamation: Current head 66f7b95 differs from pull request most recent head fe8e29e
Please upload reports for the commit fe8e29e to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
Summary by CodeRabbit
Bug Fixes
set_number_setpoint
method in theSmile
class to correctly handle temperature setpoints.Chores
Tests