Closed bouwew closed 4 weeks ago
[!CAUTION]
Review failed
The pull request is closed.
The recent changes significantly enhance the JSON configuration for various smart devices by introducing a new binary_sensors
property, which includes a battery_state
indicator. This improvement allows for better monitoring of device statuses, particularly regarding battery levels. Additionally, a new helper method for detecting low battery states has been integrated into the device management functionality, increasing overall system responsiveness and data representation. The item_count
has also been updated across multiple files, reflecting an increase in tracked items.
Files & Summary | |
---|---|
fixtures/.../all_data.json (adam_heatpump_cooling, adam_jip, adam_multiple_devices_per_zone, adam_plus_anna_new, adam_zone_per_device, m_adam_cooling, m_adam_heating) |
Added binary_sensors with battery_state , updated item_count . |
plugwise/constants.py |
Added "battery_state" to BinarySensorType , updated SmileBinarySensors with battery_state . |
plugwise/data.py |
Introduced _detect_low_batteries method, modified _update_gw_devices for battery state detection. |
plugwise/smile.py |
Modified async_update method (removed comment on updates). |
plugwise/util.py |
Added conditional logic for battery_state in common_match_cases . |
tests/.../adam/...json (adam_plus_anna_new, adam_plus_anna_new_UPDATED_DATA) |
Added binary_sensors with battery_state for devices in test JSON files. |
userdata/.../core.domain_objects.xml |
Added new <notification> element indicating low battery status for a device. |
🐇 In the realm of gadgets, bright and new,
A rabbit hops with joy, it's true!
Sensors buzzing, batteries sing,
Count them all, and let joy spring!
In our smart home, watch them glow,
With every change, our love will grow! ✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
c8d9273
) to head (4efa175
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@CoMPaTech what happened to the blacking of long lines? Is that now gone with Ruff? Or has the max width increased by a lot?
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Let's release to v1.1.0a0 for testing purposes.
Summary by CodeRabbit
New Features
binary_sensors
to track battery state for multiple devices, enhancing monitoring capabilities.Bug Fixes
Tests
Documentation
Changelog