Type P1 sensors as float

bouwew commented 2 weeks ago

Summary:

Fix/correct typing for sensors (P1, climate devices)
Less rounding, should be done in the main integration via native_precision: https://developers.home-assistant.io/blog/2023/01/25/sensor_rounding/
Update all relevant fixtures and testdata-json-files

Summary by CodeRabbit

New Features
- Enhanced precision in device configurations by converting integer values to floating-point numbers across various sensors and settings.
- Added specific model recognition for smart plugs based on their names.
Bug Fixes
- Adjusted illuminance sensor value for thermostat devices to improve accuracy.
Documentation
- Updated changelog to reflect version 1.5.1 and improvements in sensor typing and handling.
Chores
- Updated project version in pyproject.toml from "1.5.1a3" to "1.5.1".

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The changes in this pull request involve modifications to various JSON configuration files and Python scripts, primarily focusing on the representation of numeric values. Integer values have been updated to floating-point representations across multiple devices and settings, enhancing the precision of measurements. Additionally, specific sensor values and attributes have been adjusted, including updates to the illuminance sensor for a thermostat and changes to the data types of several attributes in the SmileSensors class. Overall, the updates ensure consistency in data representation across the system.

Changes

File Path	Change Summary
fixtures/legacy_anna/all_data.json	Updated illuminance sensor value from `151` to `150.8` for thermostat ID `0d266432d64443e283b5d708ae98b455`.
plugwise/constants.py	Changed data types of multiple attributes in `SmileSensors` class from `int` to `float` and vice versa.
plugwise/util.py	Modified `format_measure` function to format values based on magnitude; updated `check_model` function with new condition.
tests/data/adam/*.json	Converted numerous integer values to floats across various device configurations (e.g., `setpoint`, `lower_bound`).
tests/data/anna/*.json	Updated integer values to floating-point representations across multiple device configurations.
tests/data/p1/*.json	Changed integer sensor values to floating-point numbers in smart meter configurations.
tests/data/stretch/*.json	Modified integer values in the sensors section to floating-point numbers across various devices.

Poem

In the land of circuits and wires,
Where sensors dance and never tire,
Numbers now float, precise and bright,
Guiding devices through day and night.
A hop, a skip, a leap of cheer,
For every change, we hold so dear! 🐇✨

📜 Recent review details

**Configuration used: CodeRabbit UI** **Review profile: CHILL**

📥 Commits

Reviewing files that changed from the base of the PR and between 7095e9afc4284bff36650aa423e6e5b2f8700f42 and 46c74d7bfd1d6c59edfc6225e5681165e760b994.

📒 Files selected for processing (1)

* `pyproject.toml` (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

* pyproject.toml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` or `@coderabbitai title` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

bouwew commented 2 weeks ago

@CoMPaTech is this the rounding we want? Always show one decimal at minimum?

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (bcc498d) to head (46c74d7). Report is 12 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #648 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 20 20 Lines 3370 3368 -2 ========================================= - Hits 3370 3368 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.